]> err.no Git - linux-2.6/blobdiff - drivers/char/cyclades.c
Char: cyclades, unexport struct cyclades_card
[linux-2.6] / drivers / char / cyclades.c
index 1430e136d44d2179eabc3fcd39ebd1969ee93ba6..1b4ff138b8fffec70913c591ce724a7fa461a09a 100644 (file)
@@ -818,9 +818,6 @@ static int cy_chip_offset[] = { 0x0000,
 
 /* PCI related definitions */
 
-static unsigned short cy_pci_nboard;
-static unsigned short cy_isa_nboard;
-static unsigned short cy_nboard;
 #ifdef CONFIG_PCI
 static struct pci_device_id cy_pci_dev_id[] __devinitdata = {
        { PCI_DEVICE(PCI_VENDOR_ID_CYCLADES, PCI_DEVICE_ID_CYCLOM_Y_Lo) },      /* PCI < 1Mb */
@@ -1447,6 +1444,10 @@ static irqreturn_t cyy_interrupt(int irq, void *dev_id)
        card_base_addr = cinfo->base_addr;
        index = cinfo->bus_index;
 
+       /* card was not initialized yet (e.g. DEBUG_SHIRQ) */
+       if (unlikely(card_base_addr == NULL))
+               return IRQ_HANDLED;
+
        /* This loop checks all chips in the card.  Make a note whenever
           _any_ chip had some work to do, as this is considered an
           indication that there will be more to do.  Only when no chip
@@ -3615,11 +3616,6 @@ static int cy_tiocmget(struct tty_struct *tty, struct file *file)
                        ((status & CyCTS) ? TIOCM_CTS : 0);
        } else {
                base_addr = cy_card[card].base_addr;
-
-               if (cy_card[card].num_chips != -1) {
-                       return -EINVAL;
-               }
-
                firm_id = cy_card[card].base_addr + ID_ADDRESS;
                if (ISZLOADED(cy_card[card])) {
                        zfw_ctrl = cy_card[card].base_addr +
@@ -4053,14 +4049,6 @@ cy_ioctl(struct tty_struct *tty, struct file *file,
        case CYGETRTSDTR_INV:
                ret_val = info->rtsdtr_inv;
                break;
-       case CYGETCARDINFO:
-               if (copy_to_user(argp, &cy_card[info->card],
-                                sizeof(struct cyclades_card))) {
-                       ret_val = -EFAULT;
-                       break;
-               }
-               ret_val = 0;
-               break;
        case CYGETCD1400VER:
                ret_val = info->chip_rev;
                break;
@@ -4503,6 +4491,159 @@ static void cy_hangup(struct tty_struct *tty)
  * ---------------------------------------------------------------------
  */
 
+static void __devinit cy_init_card(struct cyclades_card *cinfo,
+               const unsigned int board)
+{
+       struct cyclades_port *info;
+       u32 mailbox;
+       unsigned int nports;
+       unsigned short chip_number;
+       int index, port;
+
+       if (IS_CYC_Z(*cinfo)) { /* Cyclades-Z */
+               mailbox = readl(&((struct RUNTIME_9060 __iomem *)
+                                    cinfo->ctl_addr)->mail_box_0);
+               nports = (mailbox == ZE_V1) ? ZE_V1_NPORTS : 8;
+               cinfo->intr_enabled = 0;
+               cinfo->nports = 0;      /* Will be correctly set later, after
+                                          Z FW is loaded */
+               spin_lock_init(&cinfo->card_lock);
+               for (port = cinfo->first_line;
+                    port < cinfo->first_line + nports; port++) {
+                       info = &cy_port[port];
+                       info->magic = CYCLADES_MAGIC;
+                       info->type = PORT_STARTECH;
+                       info->card = board;
+                       info->line = port;
+                       info->chip_rev = 0;
+                       info->flags = STD_COM_FLAGS;
+                       info->tty = NULL;
+                       if (mailbox == ZO_V1)
+                               info->xmit_fifo_size = CYZ_FIFO_SIZE;
+                       else
+                               info->xmit_fifo_size =
+                                   4 * CYZ_FIFO_SIZE;
+                       info->cor1 = 0;
+                       info->cor2 = 0;
+                       info->cor3 = 0;
+                       info->cor4 = 0;
+                       info->cor5 = 0;
+                       info->tbpr = 0;
+                       info->tco = 0;
+                       info->rbpr = 0;
+                       info->rco = 0;
+                       info->custom_divisor = 0;
+                       info->close_delay = 5 * HZ / 10;
+                       info->closing_wait = CLOSING_WAIT_DELAY;
+                       info->icount.cts = info->icount.dsr =
+                           info->icount.rng = info->icount.dcd = 0;
+                       info->icount.rx = info->icount.tx = 0;
+                       info->icount.frame = info->icount.parity = 0;
+                       info->icount.overrun = info->icount.brk = 0;
+                       info->x_char = 0;
+                       info->event = 0;
+                       info->count = 0;
+                       info->blocked_open = 0;
+                       info->default_threshold = 0;
+                       info->default_timeout = 0;
+                       INIT_WORK(&info->tqueue, do_softint);
+                       init_waitqueue_head(&info->open_wait);
+                       init_waitqueue_head(&info->close_wait);
+                       init_waitqueue_head(&info->shutdown_wait);
+                       init_waitqueue_head(&info->delta_msr_wait);
+                       /* info->session */
+                       /* info->pgrp */
+                       info->read_status_mask = 0;
+                       /* info->timeout */
+                       /* Bentson's vars */
+                       info->jiffies[0] = 0;
+                       info->jiffies[1] = 0;
+                       info->jiffies[2] = 0;
+                       info->rflush_count = 0;
+#ifdef CONFIG_CYZ_INTR
+                       init_timer(&cyz_rx_full_timer[port]);
+                       cyz_rx_full_timer[port].function = NULL;
+#endif
+               }
+#ifndef CONFIG_CYZ_INTR
+               if (!timer_pending(&cyz_timerlist)) {
+                       mod_timer(&cyz_timerlist, jiffies + 1);
+#ifdef CY_PCI_DEBUG
+                       printk("Cyclades-Z polling initialized\n");
+#endif
+               }
+#endif                         /* CONFIG_CYZ_INTR */
+
+       } else {        /* Cyclom-Y of some kind */
+               index = cinfo->bus_index;
+               spin_lock_init(&cinfo->card_lock);
+               cinfo->nports = CyPORTS_PER_CHIP * cinfo->num_chips;
+               for (port = cinfo->first_line;
+                    port < cinfo->first_line + cinfo->nports; port++) {
+                       info = &cy_port[port];
+                       info->magic = CYCLADES_MAGIC;
+                       info->type = PORT_CIRRUS;
+                       info->card = board;
+                       info->line = port;
+                       info->flags = STD_COM_FLAGS;
+                       info->tty = NULL;
+                       info->xmit_fifo_size = CyMAX_CHAR_FIFO;
+                       info->cor1 =
+                           CyPARITY_NONE | Cy_1_STOP | Cy_8_BITS;
+                       info->cor2 = CyETC;
+                       info->cor3 = 0x08;      /* _very_ small rcv threshold */
+                       info->cor4 = 0;
+                       info->cor5 = 0;
+                       info->custom_divisor = 0;
+                       info->close_delay = 5 * HZ / 10;
+                       info->closing_wait = CLOSING_WAIT_DELAY;
+                       info->icount.cts = info->icount.dsr =
+                           info->icount.rng = info->icount.dcd = 0;
+                       info->icount.rx = info->icount.tx = 0;
+                       info->icount.frame = info->icount.parity = 0;
+                       info->icount.overrun = info->icount.brk = 0;
+                       chip_number = (port - cinfo->first_line) / 4;
+                       if ((info->chip_rev =
+                            readb(cinfo->base_addr +
+                                     (cy_chip_offset[chip_number] <<
+                                      index) + (CyGFRCR << index))) >=
+                           CD1400_REV_J) {
+                               /* It is a CD1400 rev. J or later */
+                               info->tbpr = baud_bpr_60[13];   /* Tx BPR */
+                               info->tco = baud_co_60[13];     /* Tx CO */
+                               info->rbpr = baud_bpr_60[13];   /* Rx BPR */
+                               info->rco = baud_co_60[13];     /* Rx CO */
+                               info->rflow = 0;
+                               info->rtsdtr_inv = 1;
+                       } else {
+                               info->tbpr = baud_bpr_25[13];   /* Tx BPR */
+                               info->tco = baud_co_25[13];     /* Tx CO */
+                               info->rbpr = baud_bpr_25[13];   /* Rx BPR */
+                               info->rco = baud_co_25[13];     /* Rx CO */
+                               info->rflow = 0;
+                               info->rtsdtr_inv = 0;
+                       }
+                       info->x_char = 0;
+                       info->event = 0;
+                       info->count = 0;
+                       info->blocked_open = 0;
+                       info->default_threshold = 0;
+                       info->default_timeout = 0;
+                       INIT_WORK(&info->tqueue, do_softint);
+                       init_waitqueue_head(&info->open_wait);
+                       init_waitqueue_head(&info->close_wait);
+                       init_waitqueue_head(&info->shutdown_wait);
+                       init_waitqueue_head(&info->delta_msr_wait);
+                       /* info->session */
+                       /* info->pgrp */
+                       info->read_status_mask =
+                           CyTIMEOUT | CySPECHAR | CyBREAK
+                           | CyPARITY | CyFRAME | CyOVERRUN;
+                       /* info->timeout */
+               }
+       }
+}
+
 /* initialize chips on Cyclom-Y card -- return number of valid
    chips (which is number of ports/4) */
 static unsigned short __init
@@ -4681,6 +4822,7 @@ static int __init cy_detect_isa(void)
                cy_card[j].bus_index = 0;
                cy_card[j].first_line = cy_next_channel;
                cy_card[j].num_chips = cy_isa_nchan / 4;
+               cy_init_card(&cy_card[j], j);
                nboard++;
 
                /* print message */
@@ -4690,6 +4832,9 @@ static int __init cy_detect_isa(void)
                        cy_isa_irq);
                printk("%d channels starting from port %d.\n",
                        cy_isa_nchan, cy_next_channel);
+               for (j = cy_next_channel;
+                               j < cy_next_channel + cy_isa_nchan; j++)
+                       tty_register_device(cy_serial_driver, j, NULL);
                cy_next_channel += cy_isa_nchan;
        }
        return nboard;
@@ -4698,7 +4843,8 @@ static int __init cy_detect_isa(void)
 #endif                         /* CONFIG_ISA */
 }                              /* cy_detect_isa */
 
-static void plx_init(void __iomem * addr, __u32 initctl)
+#ifdef CONFIG_PCI
+static void __devinit plx_init(void __iomem * addr, __u32 initctl)
 {
        /* Reset PLX */
        cy_writel(addr + initctl, readl(addr + initctl) | 0x40000000);
@@ -4714,12 +4860,14 @@ static void plx_init(void __iomem * addr, __u32 initctl)
 static int __devinit cy_init_Ze(unsigned long cy_pci_phys0,
                unsigned long cy_pci_phys2,
                struct RUNTIME_9060 __iomem *cy_pci_addr0,
-               void __iomem *cy_pci_addr2, int cy_pci_irq,
-               struct pci_dev *pdev)
+               int cy_pci_irq, struct pci_dev *pdev)
 {
+       void __iomem *cy_pci_addr2;
        unsigned int j;
        unsigned short cy_pci_nchan;
 
+       cy_pci_addr2 = pci_iomap(pdev, 2, CyPCI_Ze_win);
+
        readl(&cy_pci_addr0->mail_box_0);
 #ifdef CY_PCI_DEBUG
        printk("Cyclades-Z/PCI: relocate winaddr=0x%lx ctladdr=0x%lx\n",
@@ -4775,6 +4923,8 @@ static int __devinit cy_init_Ze(unsigned long cy_pci_phys0,
        cy_card[j].first_line = cy_next_channel;
        cy_card[j].num_chips = -1;
        cy_card[j].pdev = pdev;
+       cy_init_card(&cy_card[j], j);
+       pci_set_drvdata(pdev, &cy_card[j]);
 
        /* print message */
 #ifdef CONFIG_CYZ_INTR
@@ -4792,411 +4942,398 @@ static int __devinit cy_init_Ze(unsigned long cy_pci_phys0,
 
        printk("%d channels starting from port %d.\n",
                cy_pci_nchan, cy_next_channel);
+       for (j = cy_next_channel; j < cy_next_channel + cy_pci_nchan; j++)
+               tty_register_device(cy_serial_driver, j, &pdev->dev);
        cy_next_channel += cy_pci_nchan;
 
        return 0;
 }
 
-/*
- * ---------------------------------------------------------------------
- * cy_detect_pci() - Test PCI bus presence and Cyclom-Ye/PCI.
- * sets global variables and return the number of PCI boards found.
- * ---------------------------------------------------------------------
- */
-static int __init cy_detect_pci(void)
+static int __devinit cy_pci_probe(struct pci_dev *pdev,
+               const struct pci_device_id *ent)
 {
-#ifdef CONFIG_PCI
-
-       struct pci_dev *pdev = NULL;
        unsigned char cyy_rev_id;
-       unsigned char cy_pci_irq = 0;
-       __u32 cy_pci_phys0, cy_pci_phys2;
+       unsigned char cy_pci_irq;
+       __u32 cy_pci_phys0, cy_pci_phys2, mailbox;
        void __iomem *cy_pci_addr0, *cy_pci_addr2;
-       unsigned short i, j, cy_pci_nchan, plx_ver;
-       unsigned short device_id, dev_index = 0;
-       __u32 mailbox;
-       __u32 ZeIndex = 0;
-       void __iomem *Ze_addr0[NR_CARDS], *Ze_addr2[NR_CARDS];
-       __u32 Ze_phys0[NR_CARDS], Ze_phys2[NR_CARDS];
-       unsigned char Ze_irq[NR_CARDS];
-       struct pci_dev *Ze_pdev[NR_CARDS];
+       unsigned int device_id;
+       unsigned short j, cy_pci_nchan, plx_ver;
        int retval;
 
-       for (i = 0; i < NR_CARDS; i++) {
-               /* look for a Cyclades card by vendor and device id */
-               while ((device_id = cy_pci_dev_id[dev_index].device) != 0) {
-                       if ((pdev = pci_get_device(PCI_VENDOR_ID_CYCLADES,
-                                                  device_id, pdev)) == NULL) {
-                               dev_index++;    /* try next device id */
-                       } else {
-                               break;  /* found a board */
-                       }
-               }
+       retval = pci_enable_device(pdev);
+       if (retval) {
+               dev_err(&pdev->dev, "cannot enable device\n");
+               return retval;
+       }
 
-               if (device_id == 0)
-                       break;
+       /* read PCI configuration area */
+       cy_pci_irq = pdev->irq;
+       cy_pci_phys0 = pci_resource_start(pdev, 0);
+       cy_pci_phys2 = pci_resource_start(pdev, 2);
+       pci_read_config_byte(pdev, PCI_REVISION_ID, &cyy_rev_id);
 
-               if (pci_enable_device(pdev))
-                       continue;
+       device_id = pdev->device & ~PCI_DEVICE_ID_MASK;
 
-               /* read PCI configuration area */
-               cy_pci_irq = pdev->irq;
-               cy_pci_phys0 = pci_resource_start(pdev, 0);
-               cy_pci_phys2 = pci_resource_start(pdev, 2);
-               pci_read_config_byte(pdev, PCI_REVISION_ID, &cyy_rev_id);
+       if (device_id == PCI_DEVICE_ID_CYCLOM_Y_Lo ||
+                       device_id == PCI_DEVICE_ID_CYCLOM_Y_Hi) {
+#ifdef CY_PCI_DEBUG
+               printk("Cyclom-Y/PCI (bus=0x0%x, pci_id=0x%x, ",
+                       pdev->bus->number, pdev->devfn);
+               printk("rev_id=%d) IRQ%d\n",
+                       cyy_rev_id, (int)cy_pci_irq);
+               printk("Cyclom-Y/PCI:found  winaddr=0x%lx "
+                       "ctladdr=0x%lx\n",
+                       (ulong)cy_pci_phys2, (ulong)cy_pci_phys0);
+#endif
 
-               device_id &= ~PCI_DEVICE_ID_MASK;
+               if (pci_resource_flags(pdev, 2) & IORESOURCE_IO) {
+                       printk("  Warning: PCI I/O bit incorrectly "
+                               "set. Ignoring it...\n");
+                       pdev->resource[2].flags &= ~IORESOURCE_IO;
+               }
 
-               if (device_id == PCI_DEVICE_ID_CYCLOM_Y_Lo ||
-                               device_id == PCI_DEVICE_ID_CYCLOM_Y_Hi) {
-#ifdef CY_PCI_DEBUG
+               /* Although we don't use this I/O region, we should
+                  request it from the kernel anyway, to avoid problems
+                  with other drivers accessing it. */
+               retval = pci_request_regions(pdev, "Cyclom-Y");
+               if (retval) {
+                       printk(KERN_ERR "cyclades: failed to reserve "
+                                       "PCI resources\n");
+                       return retval;
+               }
+#if defined(__alpha__)
+               if (device_id == PCI_DEVICE_ID_CYCLOM_Y_Lo) {   /* below 1M? */
                        printk("Cyclom-Y/PCI (bus=0x0%x, pci_id=0x%x, ",
                                pdev->bus->number, pdev->devfn);
                        printk("rev_id=%d) IRQ%d\n",
                                cyy_rev_id, (int)cy_pci_irq);
                        printk("Cyclom-Y/PCI:found  winaddr=0x%lx "
                                "ctladdr=0x%lx\n",
-                               (ulong)cy_pci_phys2, (ulong)cy_pci_phys0);
-#endif
-
-                       if (pci_resource_flags(pdev, 2) & IORESOURCE_IO) {
-                               printk("  Warning: PCI I/O bit incorrectly "
-                                       "set. Ignoring it...\n");
-                               pdev->resource[2].flags &= ~IORESOURCE_IO;
-                       }
-
-                       /* Although we don't use this I/O region, we should
-                          request it from the kernel anyway, to avoid problems
-                          with other drivers accessing it. */
-                       if (pci_request_regions(pdev, "Cyclom-Y") != 0) {
-                               printk(KERN_ERR "cyclades: failed to reserve "
-                                               "PCI resources\n");
-                               continue;
-                       }
-#if defined(__alpha__)
-                       if (device_id == PCI_DEVICE_ID_CYCLOM_Y_Lo) {   /* below 1M? */
-                               printk("Cyclom-Y/PCI (bus=0x0%x, pci_id=0x%x, ",
-                                       pdev->bus->number, pdev->devfn);
-                               printk("rev_id=%d) IRQ%d\n",
-                                       cyy_rev_id, (int)cy_pci_irq);
-                               printk("Cyclom-Y/PCI:found  winaddr=0x%lx "
-                                       "ctladdr=0x%lx\n",
-                                       (ulong)cy_pci_phys2,
-                                       (ulong)cy_pci_phys0);
-                               printk("Cyclom-Y/PCI not supported for low "
-                                       "addresses in Alpha systems.\n");
-                               i--;
-                               continue;
-                       }
+                               (ulong)cy_pci_phys2,
+                               (ulong)cy_pci_phys0);
+                       printk("Cyclom-Y/PCI not supported for low "
+                               "addresses in Alpha systems.\n");
+                       return -EIO;
+               }
 #endif
-                       cy_pci_addr0 = ioremap(cy_pci_phys0, CyPCI_Yctl);
-                       cy_pci_addr2 = ioremap(cy_pci_phys2, CyPCI_Ywin);
+               cy_pci_addr0 = pci_iomap(pdev, 0, CyPCI_Yctl);
+               cy_pci_addr2 = pci_iomap(pdev, 2, CyPCI_Ywin);
 
 #ifdef CY_PCI_DEBUG
-                       printk("Cyclom-Y/PCI: relocate winaddr=0x%lx "
-                               "ctladdr=0x%lx\n",
-                               (u_long)cy_pci_addr2, (u_long)cy_pci_addr0);
+               printk("Cyclom-Y/PCI: relocate winaddr=0x%lx "
+                       "ctladdr=0x%lx\n",
+                       (u_long)cy_pci_addr2, (u_long)cy_pci_addr0);
 #endif
-                       cy_pci_nchan = (unsigned short)(CyPORTS_PER_CHIP *
-                                       cyy_init_card(cy_pci_addr2, 1));
-                       if (cy_pci_nchan == 0) {
-                               printk("Cyclom-Y PCI host card with ");
-                               printk("no Serial-Modules at 0x%lx.\n",
-                                       (ulong) cy_pci_phys2);
-                               i--;
-                               continue;
-                       }
-                       if ((cy_next_channel + cy_pci_nchan) > NR_PORTS) {
-                               printk("Cyclom-Y/PCI found at 0x%lx ",
-                                       (ulong) cy_pci_phys2);
-                               printk("but no channels are available.\n");
-                               printk("Change NR_PORTS in cyclades.c and "
-                                               "recompile kernel.\n");
-                               return i;
-                       }
-                       /* fill the next cy_card structure available */
-                       for (j = 0; j < NR_CARDS; j++) {
-                               if (cy_card[j].base_addr == 0)
-                                       break;
-                       }
-                       if (j == NR_CARDS) {    /* no more cy_cards available */
-                               printk("Cyclom-Y/PCI found at 0x%lx ",
-                                       (ulong) cy_pci_phys2);
-                               printk("but no more cards can be used.\n");
-                               printk("Change NR_CARDS in cyclades.c and "
-                                               "recompile kernel.\n");
-                               return i;
-                       }
-
-                       /* allocate IRQ */
-                       if (request_irq(cy_pci_irq, cyy_interrupt,
-                                       IRQF_SHARED, "Cyclom-Y", &cy_card[j])) {
-                               printk("Cyclom-Y/PCI found at 0x%lx ",
-                                       (ulong) cy_pci_phys2);
-                               printk("but could not allocate IRQ%d.\n",
-                                       cy_pci_irq);
-                               return i;
-                       }
-
-                       /* set cy_card */
-                       cy_card[j].base_phys = (ulong) cy_pci_phys2;
-                       cy_card[j].ctl_phys = (ulong) cy_pci_phys0;
-                       cy_card[j].base_addr = cy_pci_addr2;
-                       cy_card[j].ctl_addr = cy_pci_addr0;
-                       cy_card[j].irq = (int)cy_pci_irq;
-                       cy_card[j].bus_index = 1;
-                       cy_card[j].first_line = cy_next_channel;
-                       cy_card[j].num_chips = cy_pci_nchan / 4;
-                       cy_card[j].pdev = pdev;
-
-                       /* enable interrupts in the PCI interface */
-                       plx_ver = readb(cy_pci_addr2 + CyPLX_VER) & 0x0f;
-                       switch (plx_ver) {
-                       case PLX_9050:
-
-                               cy_writeb(cy_pci_addr0 + 0x4c, 0x43);
+               cy_pci_nchan = (unsigned short)(CyPORTS_PER_CHIP *
+                               cyy_init_card(cy_pci_addr2, 1));
+               if (cy_pci_nchan == 0) {
+                       printk("Cyclom-Y PCI host card with ");
+                       printk("no Serial-Modules at 0x%lx.\n",
+                               (ulong) cy_pci_phys2);
+                       return -EIO;
+               }
+               if ((cy_next_channel + cy_pci_nchan) > NR_PORTS) {
+                       printk("Cyclom-Y/PCI found at 0x%lx ",
+                               (ulong) cy_pci_phys2);
+                       printk("but no channels are available.\n");
+                       printk("Change NR_PORTS in cyclades.c and "
+                                       "recompile kernel.\n");
+                       return -EIO;
+               }
+               /* fill the next cy_card structure available */
+               for (j = 0; j < NR_CARDS; j++) {
+                       if (cy_card[j].base_addr == 0)
                                break;
+               }
+               if (j == NR_CARDS) {    /* no more cy_cards available */
+                       printk("Cyclom-Y/PCI found at 0x%lx ",
+                               (ulong) cy_pci_phys2);
+                       printk("but no more cards can be used.\n");
+                       printk("Change NR_CARDS in cyclades.c and "
+                                       "recompile kernel.\n");
+                       return -EIO;
+               }
 
-                       case PLX_9060:
-                       case PLX_9080:
-                       default:        /* Old boards, use PLX_9060 */
-
-                               plx_init(cy_pci_addr0, 0x6c);
-                       /* For some yet unknown reason, once the PLX9060 reloads
-                          the EEPROM, the IRQ is lost and, thus, we have to
-                          re-write it to the PCI config. registers.
-                          This will remain here until we find a permanent
-                          fix. */
-                               pci_write_config_byte(pdev, PCI_INTERRUPT_LINE,
-                                               cy_pci_irq);
-
-                               cy_writew(cy_pci_addr0 + 0x68,
-                                       readw(cy_pci_addr0 + 0x68) | 0x0900);
-                               break;
-                       }
+               /* allocate IRQ */
+               retval = request_irq(cy_pci_irq, cyy_interrupt,
+                               IRQF_SHARED, "Cyclom-Y", &cy_card[j]);
+               if (retval) {
+                       printk("Cyclom-Y/PCI found at 0x%lx ",
+                               (ulong) cy_pci_phys2);
+                       printk("but could not allocate IRQ%d.\n",
+                               cy_pci_irq);
+                       return retval;
+               }
 
-                       /* print message */
-                       printk("Cyclom-Y/PCI #%d: 0x%lx-0x%lx, IRQ%d, ",
-                               j + 1, (ulong)cy_pci_phys2,
-                               (ulong) (cy_pci_phys2 + CyPCI_Ywin - 1),
-                               (int)cy_pci_irq);
-                       printk("%d channels starting from port %d.\n",
-                               cy_pci_nchan, cy_next_channel);
+               /* set cy_card */
+               cy_card[j].base_phys = (ulong) cy_pci_phys2;
+               cy_card[j].ctl_phys = (ulong) cy_pci_phys0;
+               cy_card[j].base_addr = cy_pci_addr2;
+               cy_card[j].ctl_addr = cy_pci_addr0;
+               cy_card[j].irq = (int)cy_pci_irq;
+               cy_card[j].bus_index = 1;
+               cy_card[j].first_line = cy_next_channel;
+               cy_card[j].num_chips = cy_pci_nchan / 4;
+               cy_card[j].pdev = pdev;
+               cy_init_card(&cy_card[j], j);
+               pci_set_drvdata(pdev, &cy_card[j]);
 
-                       cy_next_channel += cy_pci_nchan;
-               } else if (device_id == PCI_DEVICE_ID_CYCLOM_Z_Lo) {
-                       /* print message */
-                       printk("Cyclades-Z/PCI (bus=0x0%x, pci_id=0x%x, ",
-                               pdev->bus->number, pdev->devfn);
-                       printk("rev_id=%d) IRQ%d\n",
-                               cyy_rev_id, (int)cy_pci_irq);
-                       printk("Cyclades-Z/PCI: found winaddr=0x%lx "
-                               "ctladdr=0x%lx\n",
-                               (ulong)cy_pci_phys2, (ulong)cy_pci_phys0);
-                       printk("Cyclades-Z/PCI not supported for low "
-                               "addresses\n");
+               /* enable interrupts in the PCI interface */
+               plx_ver = readb(cy_pci_addr2 + CyPLX_VER) & 0x0f;
+               switch (plx_ver) {
+               case PLX_9050:
+
+                       cy_writeb(cy_pci_addr0 + 0x4c, 0x43);
                        break;
-               } else if (device_id == PCI_DEVICE_ID_CYCLOM_Z_Hi) {
-#ifdef CY_PCI_DEBUG
-                       printk("Cyclades-Z/PCI (bus=0x0%x, pci_id=0x%x, ",
-                               pdev->bus->number, pdev->devfn);
-                       printk("rev_id=%d) IRQ%d\n",
-                               cyy_rev_id, (int)cy_pci_irq);
-                       printk("Cyclades-Z/PCI: found winaddr=0x%lx "
-                               "ctladdr=0x%lx\n",
-                               (ulong) cy_pci_phys2, (ulong) cy_pci_phys0);
-#endif
-                       cy_pci_addr0 = ioremap(cy_pci_phys0, CyPCI_Zctl);
 
-                       /* Disable interrupts on the PLX before resetting it */
-                       cy_writew(cy_pci_addr0 + 0x68,
-                               readw(cy_pci_addr0 + 0x68) & ~0x0900);
+               case PLX_9060:
+               case PLX_9080:
+               default:        /* Old boards, use PLX_9060 */
 
                        plx_init(cy_pci_addr0, 0x6c);
-                       /* For some yet unknown reason, once the PLX9060 reloads
-                          the EEPROM, the IRQ is lost and, thus, we have to
-                          re-write it to the PCI config. registers.
-                          This will remain here until we find a permanent
-                          fix. */
+               /* For some yet unknown reason, once the PLX9060 reloads
+                  the EEPROM, the IRQ is lost and, thus, we have to
+                  re-write it to the PCI config. registers.
+                  This will remain here until we find a permanent
+                  fix. */
                        pci_write_config_byte(pdev, PCI_INTERRUPT_LINE,
-                                               cy_pci_irq);
+                                       cy_pci_irq);
 
-                       mailbox = (__u32)readl(&((struct RUNTIME_9060 __iomem *)
-                                       cy_pci_addr0)->mail_box_0);
+                       cy_writew(cy_pci_addr0 + 0x68,
+                               readw(cy_pci_addr0 + 0x68) | 0x0900);
+                       break;
+               }
 
-                       if (pci_resource_flags(pdev, 2) & IORESOURCE_IO) {
-                               printk("  Warning: PCI I/O bit incorrectly "
-                                       "set. Ignoring it...\n");
-                               pdev->resource[2].flags &= ~IORESOURCE_IO;
-                       }
+               /* print message */
+               printk("Cyclom-Y/PCI #%d: 0x%lx-0x%lx, IRQ%d, ",
+                       j + 1, (ulong)cy_pci_phys2,
+                       (ulong) (cy_pci_phys2 + CyPCI_Ywin - 1),
+                       (int)cy_pci_irq);
+               printk("%d channels starting from port %d.\n",
+                       cy_pci_nchan, cy_next_channel);
+               for (j = cy_next_channel;
+                               j < cy_next_channel + cy_pci_nchan; j++)
+                       tty_register_device(cy_serial_driver, j, &pdev->dev);
 
-                       /* Although we don't use this I/O region, we should
-                          request it from the kernel anyway, to avoid problems
-                          with other drivers accessing it. */
-                       if (pci_request_regions(pdev, "Cyclades-Z") != 0) {
-                               printk(KERN_ERR "cyclades: failed to reserve "
-                                       "PCI resources\n");
-                               continue;
-                       }
+               cy_next_channel += cy_pci_nchan;
+       } else if (device_id == PCI_DEVICE_ID_CYCLOM_Z_Lo) {
+               /* print message */
+               printk("Cyclades-Z/PCI (bus=0x0%x, pci_id=0x%x, ",
+                       pdev->bus->number, pdev->devfn);
+               printk("rev_id=%d) IRQ%d\n",
+                       cyy_rev_id, (int)cy_pci_irq);
+               printk("Cyclades-Z/PCI: found winaddr=0x%lx "
+                       "ctladdr=0x%lx\n",
+                       (ulong)cy_pci_phys2, (ulong)cy_pci_phys0);
+               printk("Cyclades-Z/PCI not supported for low "
+                       "addresses\n");
+               return -EIO;
+       } else if (device_id == PCI_DEVICE_ID_CYCLOM_Z_Hi) {
+#ifdef CY_PCI_DEBUG
+               printk("Cyclades-Z/PCI (bus=0x0%x, pci_id=0x%x, ",
+                       pdev->bus->number, pdev->devfn);
+               printk("rev_id=%d) IRQ%d\n",
+                       cyy_rev_id, (int)cy_pci_irq);
+               printk("Cyclades-Z/PCI: found winaddr=0x%lx "
+                       "ctladdr=0x%lx\n",
+                       (ulong) cy_pci_phys2, (ulong) cy_pci_phys0);
+#endif
+               cy_pci_addr0 = pci_iomap(pdev, 0, CyPCI_Zctl);
+
+               /* Disable interrupts on the PLX before resetting it */
+               cy_writew(cy_pci_addr0 + 0x68,
+                       readw(cy_pci_addr0 + 0x68) & ~0x0900);
+
+               plx_init(cy_pci_addr0, 0x6c);
+               /* For some yet unknown reason, once the PLX9060 reloads
+                  the EEPROM, the IRQ is lost and, thus, we have to
+                  re-write it to the PCI config. registers.
+                  This will remain here until we find a permanent
+                  fix. */
+               pci_write_config_byte(pdev, PCI_INTERRUPT_LINE,
+                                       cy_pci_irq);
 
-                       if (mailbox == ZE_V1) {
-                               cy_pci_addr2 = ioremap(cy_pci_phys2,
-                                               CyPCI_Ze_win);
-                               if (ZeIndex == NR_CARDS) {
-                                       printk("Cyclades-Ze/PCI found at "
-                                               "0x%lx but no more cards can "
-                                               "be used.\nChange NR_CARDS in "
-                                               "cyclades.c and recompile "
-                                               "kernel.\n",
-                                               (ulong)cy_pci_phys2);
-                               } else {
-                                       Ze_phys0[ZeIndex] = cy_pci_phys0;
-                                       Ze_phys2[ZeIndex] = cy_pci_phys2;
-                                       Ze_addr0[ZeIndex] = cy_pci_addr0;
-                                       Ze_addr2[ZeIndex] = cy_pci_addr2;
-                                       Ze_irq[ZeIndex] = cy_pci_irq;
-                                       Ze_pdev[ZeIndex] = pdev;
-                                       ZeIndex++;
-                               }
-                               i--;
-                               continue;
-                       } else {
-                               cy_pci_addr2 = ioremap(cy_pci_phys2,CyPCI_Zwin);
-                       }
+               mailbox = (__u32)readl(&((struct RUNTIME_9060 __iomem *)
+                               cy_pci_addr0)->mail_box_0);
+
+               if (pci_resource_flags(pdev, 2) & IORESOURCE_IO) {
+                       printk("  Warning: PCI I/O bit incorrectly "
+                               "set. Ignoring it...\n");
+                       pdev->resource[2].flags &= ~IORESOURCE_IO;
+               }
+
+               /* Although we don't use this I/O region, we should
+                  request it from the kernel anyway, to avoid problems
+                  with other drivers accessing it. */
+               retval = pci_request_regions(pdev, "Cyclades-Z");
+               if (retval) {
+                       printk(KERN_ERR "cyclades: failed to reserve "
+                               "PCI resources\n");
+                       return retval;
+               }
+
+               if (mailbox == ZE_V1) {
+                       retval = cy_init_Ze(cy_pci_phys0, cy_pci_phys2,
+                                       cy_pci_addr0, cy_pci_irq, pdev);
+                       return retval;
+               } else {
+                       cy_pci_addr2 = pci_iomap(pdev, 2, CyPCI_Zwin);
+               }
 
 #ifdef CY_PCI_DEBUG
-                       printk("Cyclades-Z/PCI: relocate winaddr=0x%lx "
-                               "ctladdr=0x%lx\n",
-                               (ulong) cy_pci_addr2, (ulong) cy_pci_addr0);
-                       if (mailbox == ZO_V1) {
-                               cy_writel(&((struct RUNTIME_9060 *)
-                                       (cy_pci_addr0))->loc_addr_base,
-                                       WIN_CREG);
-                               printk("Cyclades-8Zo/PCI: FPGA id %lx, ver "
-                                       "%lx\n", (ulong) (0xff &
-                                       readl(&((struct CUSTOM_REG *)
-                                               (cy_pci_addr2))->fpga_id)),
-                                       (ulong)(0xff &
-                                       readl(&((struct CUSTOM_REG *)
-                                               (cy_pci_addr2))->
-                                                       fpga_version)));
-                               cy_writel(&((struct RUNTIME_9060 *)
-                                       (cy_pci_addr0))->loc_addr_base,
-                                       WIN_RAM);
-                       } else {
-                               printk("Cyclades-Z/PCI: New Cyclades-Z board.  "
-                                               "FPGA not loaded\n");
-                       }
+               printk("Cyclades-Z/PCI: relocate winaddr=0x%lx "
+                       "ctladdr=0x%lx\n",
+                       (ulong) cy_pci_addr2, (ulong) cy_pci_addr0);
+               if (mailbox == ZO_V1) {
+                       cy_writel(&((struct RUNTIME_9060 *)
+                               (cy_pci_addr0))->loc_addr_base,
+                               WIN_CREG);
+                       printk("Cyclades-8Zo/PCI: FPGA id %lx, ver "
+                               "%lx\n", (ulong) (0xff &
+                               readl(&((struct CUSTOM_REG *)
+                                       (cy_pci_addr2))->fpga_id)),
+                               (ulong)(0xff &
+                               readl(&((struct CUSTOM_REG *)
+                                       (cy_pci_addr2))->
+                                               fpga_version)));
+                       cy_writel(&((struct RUNTIME_9060 *)
+                               (cy_pci_addr0))->loc_addr_base,
+                               WIN_RAM);
+               } else {
+                       printk("Cyclades-Z/PCI: New Cyclades-Z board.  "
+                                       "FPGA not loaded\n");
+               }
 #endif
-                       /* The following clears the firmware id word.  This
-                          ensures that the driver will not attempt to talk to
-                          the board until it has been properly initialized.
-                        */
-                       if ((mailbox == ZO_V1) || (mailbox == ZO_V2))
-                               cy_writel(cy_pci_addr2 + ID_ADDRESS, 0L);
-
-                       /* This must be a Cyclades-8Zo/PCI.  The extendable
-                          version will have a different device_id and will
-                          be allocated its maximum number of ports. */
-                       cy_pci_nchan = 8;
-
-                       if ((cy_next_channel + cy_pci_nchan) > NR_PORTS) {
-                               printk("Cyclades-8Zo/PCI found at 0x%lx but"
-                                       "no channels are available.\nChange "
-                                       "NR_PORTS in cyclades.c and recompile "
-                                       "kernel.\n", (ulong)cy_pci_phys2);
-                               return i;
-                       }
+               /* The following clears the firmware id word.  This
+                  ensures that the driver will not attempt to talk to
+                  the board until it has been properly initialized.
+                */
+               if ((mailbox == ZO_V1) || (mailbox == ZO_V2))
+                       cy_writel(cy_pci_addr2 + ID_ADDRESS, 0L);
+
+               /* This must be a Cyclades-8Zo/PCI.  The extendable
+                  version will have a different device_id and will
+                  be allocated its maximum number of ports. */
+               cy_pci_nchan = 8;
+
+               if ((cy_next_channel + cy_pci_nchan) > NR_PORTS) {
+                       printk("Cyclades-8Zo/PCI found at 0x%lx but"
+                               "no channels are available.\nChange "
+                               "NR_PORTS in cyclades.c and recompile "
+                               "kernel.\n", (ulong)cy_pci_phys2);
+                       return -EIO;
+               }
 
-                       /* fill the next cy_card structure available */
-                       for (j = 0; j < NR_CARDS; j++) {
-                               if (cy_card[j].base_addr == 0)
-                                       break;
-                       }
-                       if (j == NR_CARDS) {    /* no more cy_cards available */
-                               printk("Cyclades-8Zo/PCI found at 0x%lx but"
-                                       "no more cards can be used.\nChange "
-                                       "NR_CARDS in cyclades.c and recompile "
-                                       "kernel.\n", (ulong)cy_pci_phys2);
-                               return i;
-                       }
+               /* fill the next cy_card structure available */
+               for (j = 0; j < NR_CARDS; j++) {
+                       if (cy_card[j].base_addr == 0)
+                               break;
+               }
+               if (j == NR_CARDS) {    /* no more cy_cards available */
+                       printk("Cyclades-8Zo/PCI found at 0x%lx but"
+                               "no more cards can be used.\nChange "
+                               "NR_CARDS in cyclades.c and recompile "
+                               "kernel.\n", (ulong)cy_pci_phys2);
+                       return -EIO;
+               }
 #ifdef CONFIG_CYZ_INTR
-                       /* allocate IRQ only if board has an IRQ */
-                       if ((cy_pci_irq != 0) && (cy_pci_irq != 255)) {
-                               if (request_irq(cy_pci_irq, cyz_interrupt,
-                                               IRQF_SHARED, "Cyclades-Z",
-                                               &cy_card[j])) {
-                                       printk("Cyclom-8Zo/PCI found at 0x%lx "
-                                               "but could not allocate "
-                                               "IRQ%d.\n", (ulong)cy_pci_phys2,
-                                               cy_pci_irq);
-                                       return i;
-                               }
+               /* allocate IRQ only if board has an IRQ */
+               if ((cy_pci_irq != 0) && (cy_pci_irq != 255)) {
+                       retval = request_irq(cy_pci_irq, cyz_interrupt,
+                                       IRQF_SHARED, "Cyclades-Z",
+                                       &cy_card[j]);
+                       if (retval) {
+                               printk("Cyclom-8Zo/PCI found at 0x%lx "
+                                       "but could not allocate "
+                                       "IRQ%d.\n", (ulong)cy_pci_phys2,
+                                       cy_pci_irq);
+                               return retval;
                        }
+               }
 #endif                         /* CONFIG_CYZ_INTR */
 
-                       /* set cy_card */
-                       cy_card[j].base_phys = cy_pci_phys2;
-                       cy_card[j].ctl_phys = cy_pci_phys0;
-                       cy_card[j].base_addr = cy_pci_addr2;
-                       cy_card[j].ctl_addr = cy_pci_addr0;
-                       cy_card[j].irq = (int)cy_pci_irq;
-                       cy_card[j].bus_index = 1;
-                       cy_card[j].first_line = cy_next_channel;
-                       cy_card[j].num_chips = -1;
-                       cy_card[j].pdev = pdev;
-
-                       /* print message */
+               /* set cy_card */
+               cy_card[j].base_phys = cy_pci_phys2;
+               cy_card[j].ctl_phys = cy_pci_phys0;
+               cy_card[j].base_addr = cy_pci_addr2;
+               cy_card[j].ctl_addr = cy_pci_addr0;
+               cy_card[j].irq = (int)cy_pci_irq;
+               cy_card[j].bus_index = 1;
+               cy_card[j].first_line = cy_next_channel;
+               cy_card[j].num_chips = -1;
+               cy_card[j].pdev = pdev;
+               cy_init_card(&cy_card[j], j);
+               pci_set_drvdata(pdev, &cy_card[j]);
+
+               /* print message */
 #ifdef CONFIG_CYZ_INTR
-                       /* don't report IRQ if board is no IRQ */
-                       if ((cy_pci_irq != 0) && (cy_pci_irq != 255))
-                               printk("Cyclades-8Zo/PCI #%d: 0x%lx-0x%lx, "
-                                       "IRQ%d, ", j + 1, (ulong)cy_pci_phys2,
-                                       (ulong) (cy_pci_phys2 + CyPCI_Zwin - 1),
-                                       (int)cy_pci_irq);
-                       else
+               /* don't report IRQ if board is no IRQ */
+               if ((cy_pci_irq != 0) && (cy_pci_irq != 255))
+                       printk("Cyclades-8Zo/PCI #%d: 0x%lx-0x%lx, "
+                               "IRQ%d, ", j + 1, (ulong)cy_pci_phys2,
+                               (ulong) (cy_pci_phys2 + CyPCI_Zwin - 1),
+                               (int)cy_pci_irq);
+               else
 #endif                         /* CONFIG_CYZ_INTR */
-                               printk("Cyclades-8Zo/PCI #%d: 0x%lx-0x%lx, ",
-                                       j + 1, (ulong)cy_pci_phys2,
-                                       (ulong)(cy_pci_phys2 + CyPCI_Zwin - 1));
+                       printk("Cyclades-8Zo/PCI #%d: 0x%lx-0x%lx, ",
+                               j + 1, (ulong)cy_pci_phys2,
+                               (ulong)(cy_pci_phys2 + CyPCI_Zwin - 1));
 
-                       printk("%d channels starting from port %d.\n",
-                                       cy_pci_nchan, cy_next_channel);
-                       cy_next_channel += cy_pci_nchan;
-               }
+               printk("%d channels starting from port %d.\n",
+                               cy_pci_nchan, cy_next_channel);
+               for (j = cy_next_channel;
+                               j < cy_next_channel + cy_pci_nchan; j++)
+                       tty_register_device(cy_serial_driver, j, &pdev->dev);
+               cy_next_channel += cy_pci_nchan;
        }
 
-       for (; ZeIndex != 0 && i < NR_CARDS; i++) {
-               cy_pci_phys0 = Ze_phys0[0];
-               cy_pci_phys2 = Ze_phys2[0];
-               cy_pci_addr0 = Ze_addr0[0];
-               cy_pci_addr2 = Ze_addr2[0];
-               cy_pci_irq = Ze_irq[0];
-               pdev = Ze_pdev[0];
-               for (j = 0; j < ZeIndex - 1; j++) {
-                       Ze_phys0[j] = Ze_phys0[j + 1];
-                       Ze_phys2[j] = Ze_phys2[j + 1];
-                       Ze_addr0[j] = Ze_addr0[j + 1];
-                       Ze_addr2[j] = Ze_addr2[j + 1];
-                       Ze_irq[j] = Ze_irq[j + 1];
-                       Ze_pdev[j] = Ze_pdev[j + 1];
-               }
-               ZeIndex--;
-               retval = cy_init_Ze(cy_pci_phys0, cy_pci_phys2, cy_pci_addr0,
-                                       cy_pci_addr2, cy_pci_irq, pdev);
-               if (retval < 0)
-                       return i;
-       }
-       if (ZeIndex != 0) {
-               printk("Cyclades-Ze/PCI found at 0x%x but no more cards can be "
-                       "used.\nChange NR_CARDS in cyclades.c and recompile "
-                       "kernel.\n", (unsigned int)Ze_phys2[0]);
-       }
-       return i;
-#else
        return 0;
-#endif                         /* ifdef CONFIG_PCI */
-}                              /* cy_detect_pci */
+}
+
+static void __devexit cy_pci_remove(struct pci_dev *pdev)
+{
+       struct cyclades_card *cinfo = pci_get_drvdata(pdev);
+       unsigned int i;
+
+       /* non-Z with old PLX */
+       if (!IS_CYC_Z(*cinfo) && (readb(cinfo->base_addr + CyPLX_VER) & 0x0f) ==
+                       PLX_9050)
+               cy_writeb(cinfo->ctl_addr + 0x4c, 0);
+       else
+#ifndef CONFIG_CYZ_INTR
+               if (!IS_CYC_Z(*cinfo))
+#endif
+               cy_writew(cinfo->ctl_addr + 0x68,
+                               readw(cinfo->ctl_addr + 0x68) & ~0x0900);
+
+       pci_iounmap(pdev, cinfo->base_addr);
+       if (cinfo->ctl_addr)
+               pci_iounmap(pdev, cinfo->ctl_addr);
+       if (cinfo->irq
+#ifndef CONFIG_CYZ_INTR
+               && !IS_CYC_Z(*cinfo)
+#endif /* CONFIG_CYZ_INTR */
+               )
+               free_irq(cinfo->irq, cinfo);
+       pci_release_regions(pdev);
+
+       cinfo->base_addr = NULL;
+       for (i = cinfo->first_line; i < cinfo->first_line + cinfo->nports; i++){
+               cy_port[i].line = -1;
+               cy_port[i].magic = -1;
+       }
+       for (i = cinfo->first_line; i < cinfo->first_line +
+                       cinfo->nports; i++)
+               tty_unregister_device(cy_serial_driver, i);
+}
+
+static struct pci_driver cy_pci_driver = {
+       .name = "cyclades",
+       .id_table = cy_pci_dev_id,
+       .probe = cy_pci_probe,
+       .remove = __devexit_p(cy_pci_remove)
+};
+#endif
 
 /*
  * This routine prints out the appropriate serial driver version number
@@ -5308,17 +5445,12 @@ static const struct tty_operations cy_ops = {
 
 static int __init cy_init(void)
 {
-       struct cyclades_port *info;
-       struct cyclades_card *cinfo;
-       int number_z_boards = 0;
-       int board, port, i, index;
-       unsigned long mailbox;
-       unsigned short chip_number;
-       int nports;
+       unsigned int i, nboards;
+       int retval = -ENOMEM;
 
        cy_serial_driver = alloc_tty_driver(NR_PORTS);
        if (!cy_serial_driver)
-               return -ENOMEM;
+               goto err;
        show_version();
 
        /* Initialize the tty_driver structure */
@@ -5333,17 +5465,26 @@ static int __init cy_init(void)
        cy_serial_driver->init_termios = tty_std_termios;
        cy_serial_driver->init_termios.c_cflag =
            B9600 | CS8 | CREAD | HUPCL | CLOCAL;
-       cy_serial_driver->flags = TTY_DRIVER_REAL_RAW;
+       cy_serial_driver->flags = TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV;
        tty_set_operations(cy_serial_driver, &cy_ops);
 
-       if (tty_register_driver(cy_serial_driver))
-               panic("Couldn't register Cyclades serial driver\n");
+       retval = tty_register_driver(cy_serial_driver);
+       if (retval) {
+               printk(KERN_ERR "Couldn't register Cyclades serial driver\n");
+               goto err_frtty;
+       }
 
        for (i = 0; i < NR_CARDS; i++) {
                /* base_addr=0 indicates board not found */
                cy_card[i].base_addr = NULL;
        }
 
+       /* invalidate remaining cy_port structures */
+       for (i = 0; i < NR_PORTS; i++) {
+               cy_port[i].line = -1;
+               cy_port[i].magic = -1;
+       }
+
        /* the code below is responsible to find the boards. Each different
           type of board has its own detection routine. If a board is found,
           the next cy_card structure available is set by the detection
@@ -5352,182 +5493,22 @@ static int __init cy_init(void)
           the cy_next_channel. */
 
        /* look for isa boards */
-       cy_isa_nboard = cy_detect_isa();
+       nboards = cy_detect_isa();
 
+#ifdef CONFIG_PCI
        /* look for pci boards */
-       cy_pci_nboard = cy_detect_pci();
-
-       cy_nboard = cy_isa_nboard + cy_pci_nboard;
-
-       /* invalidate remaining cy_card structures */
-       for (i = 0; i < NR_CARDS; i++) {
-               if (cy_card[i].base_addr == 0) {
-                       cy_card[i].first_line = -1;
-                       cy_card[i].ctl_addr = NULL;
-                       cy_card[i].irq = 0;
-                       cy_card[i].bus_index = 0;
-                       cy_card[i].first_line = 0;
-                       cy_card[i].num_chips = 0;
-               }
-       }
-       /* invalidate remaining cy_port structures */
-       for (i = cy_next_channel; i < NR_PORTS; i++) {
-               cy_port[i].line = -1;
-               cy_port[i].magic = -1;
-       }
-
-       /* initialize per-port data structures for each valid board found */
-       for (board = 0; board < cy_nboard; board++) {
-               cinfo = &cy_card[board];
-               if (cinfo->num_chips == -1) {   /* Cyclades-Z */
-                       number_z_boards++;
-                       mailbox = readl(&((struct RUNTIME_9060 __iomem *)
-                                            cy_card[board].ctl_addr)->
-                                          mail_box_0);
-                       nports = (mailbox == ZE_V1) ? ZE_V1_NPORTS : 8;
-                       cinfo->intr_enabled = 0;
-                       cinfo->nports = 0;      /* Will be correctly set later, after 
-                                                  Z FW is loaded */
-                       spin_lock_init(&cinfo->card_lock);
-                       for (port = cinfo->first_line;
-                            port < cinfo->first_line + nports; port++) {
-                               info = &cy_port[port];
-                               info->magic = CYCLADES_MAGIC;
-                               info->type = PORT_STARTECH;
-                               info->card = board;
-                               info->line = port;
-                               info->chip_rev = 0;
-                               info->flags = STD_COM_FLAGS;
-                               info->tty = NULL;
-                               if (mailbox == ZO_V1)
-                                       info->xmit_fifo_size = CYZ_FIFO_SIZE;
-                               else
-                                       info->xmit_fifo_size =
-                                           4 * CYZ_FIFO_SIZE;
-                               info->cor1 = 0;
-                               info->cor2 = 0;
-                               info->cor3 = 0;
-                               info->cor4 = 0;
-                               info->cor5 = 0;
-                               info->tbpr = 0;
-                               info->tco = 0;
-                               info->rbpr = 0;
-                               info->rco = 0;
-                               info->custom_divisor = 0;
-                               info->close_delay = 5 * HZ / 10;
-                               info->closing_wait = CLOSING_WAIT_DELAY;
-                               info->icount.cts = info->icount.dsr =
-                                   info->icount.rng = info->icount.dcd = 0;
-                               info->icount.rx = info->icount.tx = 0;
-                               info->icount.frame = info->icount.parity = 0;
-                               info->icount.overrun = info->icount.brk = 0;
-                               info->x_char = 0;
-                               info->event = 0;
-                               info->count = 0;
-                               info->blocked_open = 0;
-                               info->default_threshold = 0;
-                               info->default_timeout = 0;
-                               INIT_WORK(&info->tqueue, do_softint);
-                               init_waitqueue_head(&info->open_wait);
-                               init_waitqueue_head(&info->close_wait);
-                               init_waitqueue_head(&info->shutdown_wait);
-                               init_waitqueue_head(&info->delta_msr_wait);
-                               /* info->session */
-                               /* info->pgrp */
-                               info->read_status_mask = 0;
-                               /* info->timeout */
-                               /* Bentson's vars */
-                               info->jiffies[0] = 0;
-                               info->jiffies[1] = 0;
-                               info->jiffies[2] = 0;
-                               info->rflush_count = 0;
-#ifdef CONFIG_CYZ_INTR
-                               init_timer(&cyz_rx_full_timer[port]);
-                               cyz_rx_full_timer[port].function = NULL;
-#endif
-                       }
-                       continue;
-               } else {        /* Cyclom-Y of some kind */
-                       index = cinfo->bus_index;
-                       spin_lock_init(&cinfo->card_lock);
-                       cinfo->nports = CyPORTS_PER_CHIP * cinfo->num_chips;
-                       for (port = cinfo->first_line;
-                            port < cinfo->first_line + cinfo->nports; port++) {
-                               info = &cy_port[port];
-                               info->magic = CYCLADES_MAGIC;
-                               info->type = PORT_CIRRUS;
-                               info->card = board;
-                               info->line = port;
-                               info->flags = STD_COM_FLAGS;
-                               info->tty = NULL;
-                               info->xmit_fifo_size = CyMAX_CHAR_FIFO;
-                               info->cor1 =
-                                   CyPARITY_NONE | Cy_1_STOP | Cy_8_BITS;
-                               info->cor2 = CyETC;
-                               info->cor3 = 0x08;      /* _very_ small rcv threshold */
-                               info->cor4 = 0;
-                               info->cor5 = 0;
-                               info->custom_divisor = 0;
-                               info->close_delay = 5 * HZ / 10;
-                               info->closing_wait = CLOSING_WAIT_DELAY;
-                               info->icount.cts = info->icount.dsr =
-                                   info->icount.rng = info->icount.dcd = 0;
-                               info->icount.rx = info->icount.tx = 0;
-                               info->icount.frame = info->icount.parity = 0;
-                               info->icount.overrun = info->icount.brk = 0;
-                               chip_number = (port - cinfo->first_line) / 4;
-                               if ((info->chip_rev =
-                                    readb(cinfo->base_addr +
-                                             (cy_chip_offset[chip_number] <<
-                                              index) + (CyGFRCR << index))) >=
-                                   CD1400_REV_J) {
-                                       /* It is a CD1400 rev. J or later */
-                                       info->tbpr = baud_bpr_60[13];   /* Tx BPR */
-                                       info->tco = baud_co_60[13];     /* Tx CO */
-                                       info->rbpr = baud_bpr_60[13];   /* Rx BPR */
-                                       info->rco = baud_co_60[13];     /* Rx CO */
-                                       info->rflow = 0;
-                                       info->rtsdtr_inv = 1;
-                               } else {
-                                       info->tbpr = baud_bpr_25[13];   /* Tx BPR */
-                                       info->tco = baud_co_25[13];     /* Tx CO */
-                                       info->rbpr = baud_bpr_25[13];   /* Rx BPR */
-                                       info->rco = baud_co_25[13];     /* Rx CO */
-                                       info->rflow = 0;
-                                       info->rtsdtr_inv = 0;
-                               }
-                               info->x_char = 0;
-                               info->event = 0;
-                               info->count = 0;
-                               info->blocked_open = 0;
-                               info->default_threshold = 0;
-                               info->default_timeout = 0;
-                               INIT_WORK(&info->tqueue, do_softint);
-                               init_waitqueue_head(&info->open_wait);
-                               init_waitqueue_head(&info->close_wait);
-                               init_waitqueue_head(&info->shutdown_wait);
-                               init_waitqueue_head(&info->delta_msr_wait);
-                               /* info->session */
-                               /* info->pgrp */
-                               info->read_status_mask =
-                                   CyTIMEOUT | CySPECHAR | CyBREAK
-                                   | CyPARITY | CyFRAME | CyOVERRUN;
-                               /* info->timeout */
-                       }
-               }
-       }
-
-#ifndef CONFIG_CYZ_INTR
-       if (number_z_boards) {
-               mod_timer(&cyz_timerlist, jiffies + 1);
-#ifdef CY_PCI_DEBUG
-               printk("Cyclades-Z polling initialized\n");
+       retval = pci_register_driver(&cy_pci_driver);
+       if (retval && !nboards)
+               goto err_unr;
 #endif
-       }
-#endif                         /* CONFIG_CYZ_INTR */
 
        return 0;
-
+err_unr:
+       tty_unregister_driver(cy_serial_driver);
+err_frtty:
+       put_tty_driver(cy_serial_driver);
+err:
+       return retval;
 }                              /* cy_init */
 
 static void __exit cy_cleanup_module(void)
@@ -5544,21 +5525,27 @@ static void __exit cy_cleanup_module(void)
 
        put_tty_driver(cy_serial_driver);
 
+#ifdef CONFIG_PCI
+       pci_unregister_driver(&cy_pci_driver);
+#endif
+
        for (i = 0; i < NR_CARDS; i++) {
                if (cy_card[i].base_addr) {
+                       /* clear interrupt */
+                       cy_writeb(cy_card[i].base_addr + Cy_ClrIntr, 0);
                        iounmap(cy_card[i].base_addr);
                        if (cy_card[i].ctl_addr)
                                iounmap(cy_card[i].ctl_addr);
                        if (cy_card[i].irq
 #ifndef CONFIG_CYZ_INTR
-                               && cy_card[i].num_chips != -1 /* not a Z card */
+                               && !IS_CYC_Z(cy_card[i])
 #endif /* CONFIG_CYZ_INTR */
                                )
                                free_irq(cy_card[i].irq, &cy_card[i]);
-#ifdef CONFIG_PCI
-                       if (cy_card[i].pdev)
-                               pci_release_regions(cy_card[i].pdev);
-#endif
+                       for (e1 = cy_card[i].first_line;
+                                       e1 < cy_card[i].first_line +
+                                       cy_card[i].nports; e1++)
+                               tty_unregister_device(cy_serial_driver, e1);
                }
        }
 } /* cy_cleanup_module */