]> err.no Git - linux-2.6/blobdiff - arch/powerpc/platforms/cell/spufs/coredump.c
[POWERPC] spufs: fix incorrect file descriptors in SPU coredump note names
[linux-2.6] / arch / powerpc / platforms / cell / spufs / coredump.c
index 5d9ad5a0307ba43b6ee47cde43cc25ebcfce907b..b962c3ab470cbe01f2f5a5d6e510866bd8a60e5a 100644 (file)
 
 #include "spufs.h"
 
-struct spufs_ctx_info {
-       struct list_head list;
-       int dfd;
-       int memsize; /* in bytes */
-       struct spu_context *ctx;
-};
-
-static LIST_HEAD(ctx_info_list);
-
-static ssize_t do_coredump_read(int num, struct spu_context *ctx, void __user *buffer,
+static ssize_t do_coredump_read(int num, struct spu_context *ctx, void *buffer,
                                size_t size, loff_t *off)
 {
        u64 data;
@@ -50,49 +41,57 @@ static ssize_t do_coredump_read(int num, struct spu_context *ctx, void __user *b
                return spufs_coredump_read[num].read(ctx, buffer, size, off);
 
        data = spufs_coredump_read[num].get(ctx);
-       ret = copy_to_user(buffer, &data, 8);
-       return ret ? -EFAULT : 8;
+       ret = snprintf(buffer, size, "0x%.16lx", data);
+       if (ret >= size)
+               return size;
+       return ++ret; /* count trailing NULL */
 }
 
 /*
  * These are the only things you should do on a core-file: use only these
  * functions to write out all the necessary info.
  */
-static int spufs_dump_write(struct file *file, const void *addr, int nr)
+static int spufs_dump_write(struct file *file, const void *addr, int nr, loff_t *foffset)
 {
-       return file->f_op->write(file, addr, nr, &file->f_pos) == nr;
-}
+       unsigned long limit = current->signal->rlim[RLIMIT_CORE].rlim_cur;
+       ssize_t written;
 
-static int spufs_dump_seek(struct file *file, loff_t off)
-{
-       if (file->f_op->llseek) {
-               if (file->f_op->llseek(file, off, 0) != off)
-                       return 0;
-       } else
-               file->f_pos = off;
-       return 1;
+       if (*foffset + nr > limit)
+               return -EIO;
+
+       written = file->f_op->write(file, addr, nr, &file->f_pos);
+       *foffset += written;
+
+       if (written != nr)
+               return -EIO;
+
+       return 0;
 }
 
-static void spufs_fill_memsize(struct spufs_ctx_info *ctx_info)
+static int spufs_dump_align(struct file *file, char *buf, loff_t new_off,
+                           loff_t *foffset)
 {
-       struct spu_context *ctx;
-       unsigned long long lslr;
+       int rc, size;
 
-       ctx = ctx_info->ctx;
-       lslr = ctx->csa.priv2.spu_lslr_RW;
-       ctx_info->memsize = lslr + 1;
+       size = min((loff_t)PAGE_SIZE, new_off - *foffset);
+       memset(buf, 0, size);
+
+       rc = 0;
+       while (rc == 0 && new_off > *foffset) {
+               size = min((loff_t)PAGE_SIZE, new_off - *foffset);
+               rc = spufs_dump_write(file, buf, size, foffset);
+       }
+
+       return rc;
 }
 
-static int spufs_ctx_note_size(struct spufs_ctx_info *ctx_info)
+static int spufs_ctx_note_size(struct spu_context *ctx, int dfd)
 {
-       int dfd, memsize, i, sz, total = 0;
+       int i, sz, total = 0;
        char *name;
        char fullname[80];
 
-       dfd = ctx_info->dfd;
-       memsize = ctx_info->memsize;
-
-       for (i = 0; spufs_coredump_read[i].name; i++) {
+       for (i = 0; spufs_coredump_read[i].name != NULL; i++) {
                name = spufs_coredump_read[i].name;
                sz = spufs_coredump_read[i].size;
 
@@ -100,39 +99,12 @@ static int spufs_ctx_note_size(struct spufs_ctx_info *ctx_info)
 
                total += sizeof(struct elf_note);
                total += roundup(strlen(fullname) + 1, 4);
-               if (!strcmp(name, "mem"))
-                       total += roundup(memsize, 4);
-               else
-                       total += roundup(sz, 4);
+               total += roundup(sz, 4);
        }
 
        return total;
 }
 
-static int spufs_add_one_context(struct file *file, int dfd)
-{
-       struct spu_context *ctx;
-       struct spufs_ctx_info *ctx_info;
-       int size;
-
-       ctx = SPUFS_I(file->f_dentry->d_inode)->i_ctx;
-       if (ctx->flags & SPU_CREATE_NOSCHED)
-               return 0;
-
-       ctx_info = kzalloc(sizeof(*ctx_info), GFP_KERNEL);
-       if (unlikely(!ctx_info))
-               return -ENOMEM;
-
-       ctx_info->dfd = dfd;
-       ctx_info->ctx = ctx;
-
-       spufs_fill_memsize(ctx_info);
-
-       size = spufs_ctx_note_size(ctx_info);
-       list_add(&ctx_info->list, &ctx_info_list);
-       return size;
-}
-
 /*
  * The additional architecture-specific notes for Cell are various
  * context files in the spu context.
@@ -142,33 +114,60 @@ static int spufs_add_one_context(struct file *file, int dfd)
  * internal functionality to dump them without needing to actually
  * open the files.
  */
-static int spufs_arch_notes_size(void)
+static struct spu_context *coredump_next_context(int *fd)
 {
        struct fdtable *fdt = files_fdtable(current->files);
-       int size = 0, fd;
+       struct file *file;
+       struct spu_context *ctx = NULL;
 
-       for (fd = 0; fd < fdt->max_fds; fd++) {
-               if (FD_ISSET(fd, fdt->open_fds)) {
-                       struct file *file = fcheck(fd);
+       for (; *fd < fdt->max_fds; (*fd)++) {
+               if (!FD_ISSET(*fd, fdt->open_fds))
+                       continue;
 
-                       if (file && file->f_op == &spufs_context_fops) {
-                               int rval = spufs_add_one_context(file, fd);
-                               if (rval < 0)
-                                       break;
-                               size += rval;
-                       }
-               }
+               file = fcheck(*fd);
+
+               if (!file || file->f_op != &spufs_context_fops)
+                       continue;
+
+               ctx = SPUFS_I(file->f_dentry->d_inode)->i_ctx;
+               if (ctx->flags & SPU_CREATE_NOSCHED)
+                       continue;
+
+               break;
        }
 
-       return size;
+       return ctx;
 }
 
-static void spufs_arch_write_note(struct spufs_ctx_info *ctx_info, int i,
-                               struct file *file)
+int spufs_coredump_extra_notes_size(void)
 {
        struct spu_context *ctx;
+       int size = 0, rc, fd;
+
+       fd = 0;
+       while ((ctx = coredump_next_context(&fd)) != NULL) {
+               rc = spu_acquire_saved(ctx);
+               if (rc)
+                       break;
+               rc = spufs_ctx_note_size(ctx, fd);
+               spu_release_saved(ctx);
+               if (rc < 0)
+                       break;
+
+               size += rc;
+
+               /* start searching the next fd next time */
+               fd++;
+       }
+
+       return size;
+}
+
+static int spufs_arch_write_note(struct spu_context *ctx, int i,
+                                 struct file *file, int dfd, loff_t *foffset)
+{
        loff_t pos = 0;
-       int sz, dfd, rc, total = 0;
+       int sz, rc, nread, total = 0;
        const int bufsz = PAGE_SIZE;
        char *name;
        char fullname[80], *buf;
@@ -176,64 +175,75 @@ static void spufs_arch_write_note(struct spufs_ctx_info *ctx_info, int i,
 
        buf = (void *)get_zeroed_page(GFP_KERNEL);
        if (!buf)
-               return;
+               return -ENOMEM;
 
-       dfd = ctx_info->dfd;
        name = spufs_coredump_read[i].name;
-
-       if (!strcmp(name, "mem"))
-               sz = ctx_info->memsize;
-       else
-               sz = spufs_coredump_read[i].size;
-
-       ctx = ctx_info->ctx;
-       if (!ctx)
-               goto out;
+       sz = spufs_coredump_read[i].size;
 
        sprintf(fullname, "SPU/%d/%s", dfd, name);
        en.n_namesz = strlen(fullname) + 1;
        en.n_descsz = sz;
        en.n_type = NT_SPU;
 
-       if (!spufs_dump_write(file, &en, sizeof(en)))
+       rc = spufs_dump_write(file, &en, sizeof(en), foffset);
+       if (rc)
                goto out;
-       if (!spufs_dump_write(file, fullname, en.n_namesz))
+
+       rc = spufs_dump_write(file, fullname, en.n_namesz, foffset);
+       if (rc)
                goto out;
-       if (!spufs_dump_seek(file, roundup((unsigned long)file->f_pos, 4)))
+
+       rc = spufs_dump_align(file, buf, roundup(*foffset, 4), foffset);
+       if (rc)
                goto out;
 
        do {
-               rc = do_coredump_read(i, ctx, buf, bufsz, &pos);
-               if (rc > 0) {
-                       if (!spufs_dump_write(file, buf, rc))
+               nread = do_coredump_read(i, ctx, buf, bufsz, &pos);
+               if (nread > 0) {
+                       rc = spufs_dump_write(file, buf, nread, foffset);
+                       if (rc)
                                goto out;
-                       total += rc;
+                       total += nread;
                }
-       } while (rc == bufsz && total < sz);
+       } while (nread == bufsz && total < sz);
+
+       if (nread < 0) {
+               rc = nread;
+               goto out;
+       }
+
+       rc = spufs_dump_align(file, buf, roundup(*foffset - total + sz, 4),
+                             foffset);
 
-       spufs_dump_seek(file, roundup((unsigned long)file->f_pos
-                                               - total + sz, 4));
 out:
        free_page((unsigned long)buf);
+       return rc;
 }
 
-static void spufs_arch_write_notes(struct file *file)
+int spufs_coredump_extra_notes_write(struct file *file, loff_t *foffset)
 {
-       int j;
-       struct spufs_ctx_info *ctx_info, *next;
-
-       list_for_each_entry_safe(ctx_info, next, &ctx_info_list, list) {
-               spu_acquire_saved(ctx_info->ctx);
-               for (j = 0; j < spufs_coredump_num_notes; j++)
-                       spufs_arch_write_note(ctx_info, j, file);
-               spu_release(ctx_info->ctx);
-               list_del(&ctx_info->list);
-               kfree(ctx_info);
+       struct spu_context *ctx;
+       int fd, j, rc;
+
+       fd = 0;
+       while ((ctx = coredump_next_context(&fd)) != NULL) {
+               rc = spu_acquire_saved(ctx);
+               if (rc)
+                       return rc;
+
+               for (j = 0; spufs_coredump_read[j].name != NULL; j++) {
+                       rc = spufs_arch_write_note(ctx, j, file, fd, foffset);
+                       if (rc) {
+                               spu_release_saved(ctx);
+                               return rc;
+                       }
+               }
+
+               spu_release_saved(ctx);
+
+               /* start searching the next fd next time */
+               fd++;
        }
-}
 
-struct spu_coredump_calls spufs_coredump_calls = {
-       .arch_notes_size = spufs_arch_notes_size,
-       .arch_write_notes = spufs_arch_write_notes,
-       .owner = THIS_MODULE,
-};
+       return 0;
+}