]> err.no Git - linux-2.6/commitdiff
lguest: net block unneeded receive queue update notifications
authorRusty Russell <rusty@rustcorp.com.au>
Tue, 29 Jul 2008 14:58:35 +0000 (09:58 -0500)
committerRusty Russell <rusty@rustcorp.com.au>
Mon, 28 Jul 2008 23:58:35 +0000 (09:58 +1000)
Number of exits transmitting 10GB Guest->Host before:
network xmit 7858610 recv 118136

After:
network xmit 7750233 recv 1

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Documentation/lguest/lguest.c

index 31a688e105ca316a2fb1d04fa19e3f46dbb3ec8f..46f4c5b09e9e9c41ccdfeafcb150407aa6016126 100644 (file)
@@ -933,6 +933,11 @@ static bool handle_tun_input(int fd, struct device *dev)
                /* FIXME: Actually want DRIVER_ACTIVE here. */
                if (dev->desc->status & VIRTIO_CONFIG_S_DRIVER_OK)
                        warn("network: no dma buffer!");
+
+               /* Now tell it we want to know if new things appear. */
+               dev->vq->vring.used->flags &= ~VRING_USED_F_NO_NOTIFY;
+               wmb();
+
                /* We'll turn this back on if input buffers are registered. */
                return false;
        } else if (out_num)
@@ -969,6 +974,13 @@ static void enable_fd(int fd, struct virtqueue *vq)
        write(waker_fd, &vq->dev->fd, sizeof(vq->dev->fd));
 }
 
+static void net_enable_fd(int fd, struct virtqueue *vq)
+{
+       /* We don't need to know again when Guest refills receive buffer. */
+       vq->vring.used->flags |= VRING_USED_F_NO_NOTIFY;
+       enable_fd(fd, vq);
+}
+
 /* When the Guest tells us they updated the status field, we handle it. */
 static void update_device_status(struct device *dev)
 {
@@ -1426,7 +1438,7 @@ static void setup_tun_net(char *arg)
 
        /* Network devices need a receive and a send queue, just like
         * console. */
-       add_virtqueue(dev, VIRTQUEUE_NUM, enable_fd);
+       add_virtqueue(dev, VIRTQUEUE_NUM, net_enable_fd);
        add_virtqueue(dev, VIRTQUEUE_NUM, handle_net_output);
 
        /* We need a socket to perform the magic network ioctls to bring up the