]> err.no Git - linux-2.6/commitdiff
irda: Fix netlink error path return value
authorJulius Volz <juliusv@google.com>
Tue, 8 Jul 2008 10:07:43 +0000 (03:07 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 8 Jul 2008 10:07:43 +0000 (03:07 -0700)
Fix an incorrect return value check of genlmsg_put() in irda_nl_get_mode().
genlmsg_put() does not use ERR_PTR() to encode return values, it just
returns NULL on error.

Signed-off-by: Julius Volz <juliusv@google.com>
Signed-off-by: Samuel Ortiz <samuel@sortiz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/irda/irnetlink.c

index 9e1fb82e322005a3749d4213c91612eadb73d1c3..2f05ec1037ab32322838dfd2cf851e66050ceb0c 100644 (file)
@@ -101,8 +101,8 @@ static int irda_nl_get_mode(struct sk_buff *skb, struct genl_info *info)
 
        hdr = genlmsg_put(msg, info->snd_pid, info->snd_seq,
                          &irda_nl_family, 0,  IRDA_NL_CMD_GET_MODE);
-       if (IS_ERR(hdr)) {
-               ret = PTR_ERR(hdr);
+       if (hdr == NULL) {
+               ret = -EMSGSIZE;
                goto err_out;
        }