]> err.no Git - linux-2.6/commit
wan: Missing capability checks in sbni_ioctl()
authorEugene Teo <eugeneteo@kernel.sg>
Wed, 27 Aug 2008 11:50:30 +0000 (04:50 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 27 Aug 2008 11:50:30 +0000 (04:50 -0700)
commitf2455eb176ac87081bbfc9a44b21c7cd2bc1967e
tree63874579df35e6938faa973f476a4fe803f5282c
parent6c36810a731a422535d838cdb440f332c1d91017
wan: Missing capability checks in sbni_ioctl()

There are missing capability checks in the following code:

1300 static int
1301 sbni_ioctl( struct net_device  *dev,  struct ifreq  *ifr,  int  cmd)
1302 {
[...]
1319     case  SIOCDEVRESINSTATS :
1320         if( current->euid != 0 )    /* root only */
1321             return  -EPERM;
[...]
1336     case  SIOCDEVSHWSTATE :
1337         if( current->euid != 0 )    /* root only */
1338             return  -EPERM;
[...]
1357     case  SIOCDEVENSLAVE :
1358         if( current->euid != 0 )    /* root only */
1359             return  -EPERM;
[...]
1372     case  SIOCDEVEMANSIPATE :
1373         if( current->euid != 0 )    /* root only */
1374             return  -EPERM;

Here's my proposed fix:

Missing capability checks.

Signed-off-by: Eugene Teo <eugeneteo@kernel.sg>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/wan/sbni.c