]> err.no Git - linux-2.6/commit
firewire: fw-ohci: write selfIDBufferPtr before LinkControl.rcvSelfID
authorStefan Richter <stefanr@s5r6.in-berlin.de>
Thu, 5 Jun 2008 18:50:53 +0000 (20:50 +0200)
committerStefan Richter <stefanr@s5r6.in-berlin.de>
Wed, 18 Jun 2008 22:12:35 +0000 (00:12 +0200)
commitaffc9c24ade666f9903163c12686da567dbfe06f
tree3beff66f52c3201bd24b6dd6777c2942373c9881
parente896ec4302f45fdaf2fc78aec0093eca5478fe28
firewire: fw-ohci: write selfIDBufferPtr before LinkControl.rcvSelfID

OHCI 1.1 clause 5.10 requires that selfIDBufferPtr is valid when a 1 is
written into LinkControl.rcvSelfID.

This driver bug has so far not been known to cause harm because most
chips obviously accept a later selfIDBufferPtr write, at least before
HCControl.linkEnable is written.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Signed-off-by: Jarod Wilson <jwilson@redhat.com>
Signed-off-by: Kristian Høgsberg <krh@redhat.com>
drivers/firewire/fw-ohci.c