]> err.no Git - linux-2.6/commit
libata-sff: kill spurious WARN_ON() in ata_hsm_move()
authorTejun Heo <tj@kernel.org>
Fri, 29 Aug 2008 14:27:43 +0000 (16:27 +0200)
committerJeff Garzik <jgarzik@redhat.com>
Mon, 8 Sep 2008 16:15:38 +0000 (12:15 -0400)
commit9c2676b61a5a4b6d99e65fb2f438fb3914302eda
treeb52a7d20fbebee27edefac35ff5139c0daef0df2
parent2fd673ecf0378ddeeeb87b3605e50212e0c0ddc6
libata-sff: kill spurious WARN_ON() in ata_hsm_move()

On HSM_ST_ERR, ata_hsm_move() triggers WARN_ON() if AC_ERR_DEV or
AC_ERR_HSM is not set.  PHY events may trigger HSM_ST_ERR with other
error codes and, with or without it, there just isn't much reason to
do WARN_ON() on it.  Even if error code is not set there, core EH
logic won't have any problem dealing with the error condition.

OSDL bz#11065 reports this problem.

Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
drivers/ata/libata-sff.c