]> err.no Git - linux-2.6/commit
bridge: don't allow setting hello time to zero
authorStephen Hemminger <shemminger@vyatta.com>
Mon, 8 Sep 2008 20:44:40 +0000 (13:44 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 8 Sep 2008 20:46:54 +0000 (13:46 -0700)
commit8d4698f7a54a492a1b96c505b30fe750ae3e61d5
tree4bec6c7dcf06bb5df9645d702d554a071007b83a
parentd315492b1a6ba29da0fa2860759505ae1b2db857
bridge: don't allow setting hello time to zero

Dushan Tcholich reports that on his system ksoftirqd can consume
between %6 to %10 of cpu time, and cause ~200 context switches per
second.

He then correlated this with a report by bdupree@techfinesse.com:

http://marc.info/?l=linux-kernel&m=119613299024398&w=2

and the culprit cause seems to be starting the bridge interface.
In particular, when starting the bridge interface, his scripts
are specifying a hello timer interval of "0".

The bridge hello time can't be safely set to values less than 1
second, otherwise it is possible to end up with a runaway timer.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/bridge/br_ioctl.c
net/bridge/br_sysfs_br.c