]> err.no Git - linux-2.6/commit
[PATCH] USB Storage: retry hard errors
authorMatthew Dharm <mdharm-usb@one-eyed-alien.net>
Tue, 7 Jun 2005 00:22:42 +0000 (17:22 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 27 Jun 2005 21:44:03 +0000 (14:44 -0700)
commit86dbde9cbdfe8bc2c2dfe5d33027d3acc55e0470
tree0dcfa65023ca3df8816bd7bbb42c19b443096a48
parent4d07ef762fc8d6d35ecc1511a3b953a733a61a5f
[PATCH] USB Storage: retry hard errors

This patch started life as as527, and was rediffed by me.

Since the IDE interface doesn't convey much information about types of
errors, many USB-IDE adapters report all low-level errors with SK = 0x04,
which is supposed to be used only for non-recoverable errors.  As a result
the SCSI midlayer doesn't retry the command.  But quite often a retry
would succeed, whereas an unnecessary retry doesn't really hurt anything.

This patch uses a recently-implemented flag to tell the SCSI midlayer that
such hardware errors should be retried.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Matthew Dharm <mdharm-usb@one-eyed-alien.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/storage/scsiglue.c