]> err.no Git - linux-2.6/commit
[XFS] Fix regression introduced by remount fixup
authorChristoph Hellwig <hch@infradead.org>
Wed, 17 Sep 2008 06:49:33 +0000 (16:49 +1000)
committerLachlan McIlroy <lachlan@redback.melbourne.sgi.com>
Wed, 17 Sep 2008 06:49:33 +0000 (16:49 +1000)
commit6efdf281777eb07fac28ac2b2d7df1e619ee6da1
tree300ee54e4a9a7d7180a9b6770a51d42ad544b989
parent31bd61f2bb79e098117d823e054342b03aa87668
[XFS] Fix regression introduced by remount fixup

Logically we would return an error in xfs_fs_remount code to prevent users
from believing they might have changed mount options using remount which
can't be changed.

But unfortunately mount(8) adds all options from mtab and fstab to the
mount arguments in some cases so we can't blindly reject options, but have
to check for each specified option if it actually differs from the
currently set option and only reject it if that's the case.

Until that is implemented we return success for every remount request, and
silently ignore all options that we can't actually change.

SGI-PV: 985710

SGI-Modid: xfs-linux-melb:xfs-kern:31908a

Signed-off-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Tim Shimmin <tes@sgi.com>
Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>
fs/xfs/linux-2.6/xfs_super.c