]> err.no Git - linux-2.6/commit
tg3: Fix 'scheduling while atomic' errors
authorMatt Carlson <mcarlson@broadcom.com>
Tue, 5 Aug 2008 06:17:34 +0000 (23:17 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 5 Aug 2008 06:18:20 +0000 (23:18 -0700)
commit2f751b67a8be698cec52f786910ef4f0beffe9a7
treece1ea9366803f667e68dd57eaf70261aa65bd6a3
parentcc6533e98a7f3cb7fce9d740da49195c7aa523a4
tg3: Fix 'scheduling while atomic' errors

This patch fixes the 'scheduling while atomic' errors introduced by
commit 12dac0756d357325b107fe6ec24921ec38661839 ("tg3: adapt tg3 to
use reworked PCI PM code").

The first hunk of the patch removes an unnecessary
tg3_set_power_state() call.  The chip will already be in the D0 state
either due to a chip reset or through a previous call to
tg3_set_power_state().

The second hunk of the patch moves the tg3_set_power_state() call
outside the critical section guarded by tg3_full_lock() and
tg3_full_unlock() functions.  The power state of the device is and
should be outside the lock's domain and all other
tg3_set_power_state() calls support this.

Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/tg3.c