]> err.no Git - linux-2.6/commit
virtio_net: Fix skb->csum_start computation
authorMark McLoughlin <markmc@redhat.com>
Sun, 8 Jun 2008 10:49:00 +0000 (20:49 +1000)
committerJeff Garzik <jgarzik@redhat.com>
Tue, 10 Jun 2008 22:20:29 +0000 (18:20 -0400)
commit23cde76d801246a702e7a84c3fe3d655b35c89a1
tree532e7c5b8b4e47599bf93af1b4e618fa5891b5d9
parent00aaea2f95d73d4e2b5e45cf77c3cbb16c59e87f
virtio_net: Fix skb->csum_start computation

hdr->csum_start is the offset from the start of the ethernet
header to the transport layer checksum field. skb->csum_start
is the offset from skb->head.

skb_partial_csum_set() assumes that skb->data points to the
ethernet header - i.e. it computes skb->csum_start by adding
the headroom to hdr->csum_start.

Since eth_type_trans() skb_pull()s the ethernet header,
skb_partial_csum_set() should be called before
eth_type_trans().

(Without this patch, GSO packets from a guest to the world outside the
host are corrupted).

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
drivers/net/virtio_net.c