]> err.no Git - linux-2.6/commit
[SCSI] NCR5380: Fix bugs and canonicalize irq handler usage
authorJeff Garzik <jeff@garzik.org>
Mon, 12 Nov 2007 00:52:05 +0000 (19:52 -0500)
committerJames Bottomley <James.Bottomley@HansenPartnership.com>
Sun, 25 Nov 2007 10:19:26 +0000 (12:19 +0200)
commit1e641664301744f0d381de43ae1e12343e60b479
tree974c977e1dd9787c943d16b771372f08b48f346d
parent86e8dfc5603ed76917eed0a9dd9e85a1e1a8b162
[SCSI] NCR5380: Fix bugs and canonicalize irq handler usage

* Always pass the same value to free_irq() that we pass to
  request_irq().  This fixes several bugs.

* Always call NCR5380_intr() with 'irq' and 'dev_id' arguments.

  Note, scsi_falcon_intr() is the only case now where dev_id is not the
  scsi_host.

* Always pass Scsi_Host to request_irq().  For most cases, the drivers
  already did so, and I merely neated the source code line.  In other
  cases, either NULL or a non-sensical value was passed, verified to be
  unused, then changed to be Scsi_Host in anticipation of the future.

In addition to the bugs fixes, this change makes the interface usage
consistent, which in turn enables the possibility of directly
referencing Scsi_Host from all NCR5380_intr() invocations.

Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
drivers/scsi/atari_scsi.c
drivers/scsi/dtc.c
drivers/scsi/g_NCR5380.c
drivers/scsi/mac_scsi.c
drivers/scsi/pas16.c
drivers/scsi/sun3_scsi.c
drivers/scsi/sun3_scsi_vme.c
drivers/scsi/t128.c